On Sun, 27 Jul 1997, Kurt Huwig wrote:
> On Sun, 27 Jul 1997, Rogier Wolff wrote:
> > Kurt Huwig wrote:
> > > I looked through dejanews and found Rogier's patch. It did not patch in
> > > directly, because the sources have changed a little bit, so I did it by
> > > hand, together with minor changes:
> >
> > Kurt, there should be a followup that had a slightly different patch.
> > There is an attribute bit that says "this file needs safe delete",
> > which is currently unused. I didn't know that, so I wrote it without
> > using that bit. Someon else volunteerd "but there is a bit, for which
> > you just made the implementation".
>
> After some time, I found the patch.
Darren made some mistakes in his patch:
- he made the name of the directory adjustable via define, but overlooked
that you need the length of it in 'ext2_lookup'. So it would only work
if you use a name with 12 letters. I don't want to use 'strlen' here.
- he did not move the 'ext2_unlink' code after 'do_ext2_rename', so it
won't compile at all. A
- he changed some of the 'printk' into 'ext2_debug' but still every move
is reported via one printk...annoying
- you/he said 'moveing' instead of 'moving'...ok my English is worse ;-)
I included the reference to 'chattr' and 'lsattr' in the config help. I
think this will prevent any FAQs about how to set the 'u'-bit... ;-)