2.6.9

diff -Nru a/Makefile b/Makefile
--- a/Makefile   2004-10-18 14:56:33 -07:00
+++ b/Makefile   2004-10-18 14:56:34 -07:00
@@ -1,6 +1,6 @@
 VERSION = 2
 PATCHLEVEL = 6
-SUBLEVEL = 8
+SUBLEVEL = 9
 EXTRAVERSION =
 NAME=Zonked Quokka
 
@@ -102,7 +102,7 @@
 # check that the output directory actually exists
 saved-output := $(KBUILD_OUTPUT)
 KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
-$(if $(wildcard $(KBUILD_OUTPUT)),, \
+$(if $(KBUILD_OUTPUT),, \
      $(error output directory "$(saved-output)" does not exist))
 
 .PHONY: $(MAKECMDGOALS)
@@ -141,7 +141,25 @@
 
 export srctree objtree VPATH TOPDIR
 
-KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)
+nullstring :=
+space      := $(nullstring) # end of line
+
+# Take the contents of any files called localversion* and the config
+# variable CONFIG_LOCALVERSION and append them to KERNELRELEASE. Be
+# careful not to include files twice if building in the source
+# directory. LOCALVERSION from the command line override all of this
+
+ifeq ($(objtree),$(srctree))
+localversion-files := $(wildcard $(srctree)/localversion*)
+else
+localversion-files := $(wildcard $(objtree)/localversion* $(srctree)/localversion*)
+endif
+
+LOCALVERSION = $(subst $(space),, \
+          $(shell cat /dev/null $(localversion-files)) \
+          $(subst ",,$(CONFIG_LOCALVERSION)))
+
+KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)$(LOCALVERSION)
 
 # SUBARCH tells the usermode build what the underlying arch is.  That is set
 # first, and if a usermode build is happening, the "ARCH=um" on the command
@@ -256,9 +274,32 @@
   quiet=silent_
 endif
 
-check_gcc = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)+
"; fi ;)
+export quiet Q KBUILD_VERBOSE
+
+######
+# cc support functions to be used (only) in arch/$(ARCH)/Makefile
+# See documentation in Documentation/kbuild/makefiles.txt
+
+# cc-option
+# Usage: cflags-y += $(call gcc-option, -march=winchip-c6, -march=i586)
+
+cc-option = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+             > /dev/null 2>&1; then echo "$(1)"; else echo "$(2)"; fi ;)
+
+# For backward compatibility
+check_gcc = $(warning check_gcc is deprecated - use cc-option) \
+            $(call cc-option, $(1),$(2))
+
+# cc-option-yn
+# Usage: flag := $(call gcc-option-yn, -march=winchip-c6)
+cc-option-yn = $(shell if $(CC) $(CFLAGS) $(1) -S -o /dev/null -xc /dev/null \
+                > /dev/null 2>&1; then echo "y"; else echo "n"; fi;)
+
+# cc-version
+# Usage gcc-ver := $(call cc-version $(CC))
+cc-version = $(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-version.sh \
+              $(if $(1), $(1), $(CC)))
 
-export quiet Q KBUILD_VERBOSE check_gcc
 
 # Look for make include files relative to root of kernel src
 MAKEFLAGS += --include-dir=$(srctree)
@@ -285,6 +326,7 @@
 KALLSYMS   = scripts/kallsyms
 PERL      = perl
 CHECK      = sparse
+CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__
 MODFLAGS   = -DMODULE
 CFLAGS_MODULE   = $(MODFLAGS)
 AFLAGS_MODULE   = $(MODFLAGS)
@@ -294,19 +336,23 @@
 
 NOSTDINC_FLAGS  = -nostdinc -iwithprefix include
 
-CPPFLAGS        := -D__KERNEL__ -Iinclude \
-         $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
+# Use LINUXINCLUDE when you must reference the include/ directory.
+# Needed to be compatible with the O= option
+LINUXINCLUDE    := -Iinclude \
+                   $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
+
+CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
 CFLAGS       := -Wall -Wstrict-prototypes -Wno-trigraphs \
            -fno-strict-aliasing -fno-common
 AFLAGS      := -D__ASSEMBLY__
 
-export   VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION KERNELRELEASE ARCH \
-   CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC \
+export   VERSION PATCHLEVEL SUBLEVEL EXTRAVERSION LOCALVERSION KERNELRELEASE \
+   ARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC \
    CPP AR NM STRIP OBJCOPY OBJDUMP MAKE AWK GENKSYMS PERL UTS_MACHINE \
-   HOSTCXX HOSTCXXFLAGS LDFLAGS_BLOB LDFLAGS_MODULE CHECK
+   HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS
 
-export CPPFLAGS NOSTDINC_FLAGS OBJCOPYFLAGS LDFLAGS
+export CPPFLAGS NOSTDINC_FLAGS LINUXINCLUDE OBJCOPYFLAGS LDFLAGS
 export CFLAGS CFLAGS_KERNEL CFLAGS_MODULE 
 export AFLAGS AFLAGS_KERNEL AFLAGS_MODULE
 
@@ -428,15 +474,6 @@
 include/linux/autoconf.h: ;
 endif
 
-include $(srctree)/arch/$(ARCH)/Makefile
-
-# Default kernel image to build when no specific target is given.
-# KBUILD_IMAGE may be overruled on the commandline or
-# set in the environment
-# Also any assingments in arch/$(ARCH)/Makefiel take precedence over
-# this default value
-export KBUILD_IMAGE ?= vmlinux
-
 # The all: target is the default when no target is given on the
 # command line.
 # This allow a user to issue only 'make' to build a kernel including modules
@@ -458,7 +495,16 @@
 endif
 
 # warn about C99 declaration after statement
-CFLAGS += $(call check_gcc,-Wdeclaration-after-statement,)
+CFLAGS += $(call cc-option,-Wdeclaration-after-statement,)
+
+include $(srctree)/arch/$(ARCH)/Makefile
+
+# Default kernel image to build when no specific target is given.
+# KBUILD_IMAGE may be overruled on the commandline or
+# set in the environment
+# Also any assingments in arch/$(ARCH)/Makefiel take precedence over
+# this default value
+export KBUILD_IMAGE ?= vmlinux
 
 #
 # INSTALL_PATH specifies where to place the updated kernel and system map
@@ -499,67 +545,93 @@
 
 # Build vmlinux
 # ---------------------------------------------------------------------------
+# vmlinux is build from the objects selected by $(vmlinux-init) and
+# $(vmlinux-main). Most are built-in.o files from top-level directories
+# in the kernel tree, others are specified in arch/$(ARCH)Makefile.
+# Ordering when linking is important, and $(vmlinux-init) must be first.
+#
+# vmlinux
+#   ^
+#   |
+#   +-< $(vmlinux-init)
+#   |   +--< init/version.o + more
+#   |
+#   +--< $(vmlinux-main)
+#   |    +--< driver/built-in.o mm/built-in.o + more
+#   |
+#   +-< kallsyms.o (see description in CONFIG_KALLSYMS section)
+#
+# vmlinux version (uname -v) cannot be updated during normal
+# descending-into-subdirs phase since we do not yet know if we need to
+# update vmlinux.
+# Therefore this step is delayed until just before final link of vmlinux -
+# except in the kallsyms case where it is done just before adding the
+# symbols to the kernel.
+#
+# System.map is generated to document addresses of all kernel symbols
 
-#   This is a bit tricky: If we need to relink vmlinux, we want
-#   the version number incremented, which means recompile init/version.o
-#   and relink init/init.o. However, we cannot do this during the
-#       normal descending-into-subdirs phase, since at that time
-#       we cannot yet know if we will need to relink vmlinux.
-#   So we descend into init/ inside the rule for vmlinux again.
-head-y += $(HEAD)
-vmlinux-objs := $(head-y) $(init-y) $(core-y) $(libs-y) $(drivers-y) $(net-y)
-
-quiet_cmd_vmlinux__ = LD      $@
-define cmd_vmlinux__
-   $(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) $(head-y) $(init-y) \
-   --start-group \
-   $(core-y) \
-   $(libs-y) \
-   $(drivers-y) \
-   $(net-y) \
-   --end-group \
-   $(filter .tmp_kallsyms%,$^) \
-   -o $@
-endef
-
-#   set -e makes the rule exit immediately on error
+vmlinux-init := $(head-y) $(init-y)
+vmlinux-main := $(core-y) $(libs-y) $(drivers-y) $(net-y)
+vmlinux-all  := $(vmlinux-init) $(vmlinux-main)
+vmlinux-lds  := arch/$(ARCH)/kernel/vmlinux.lds
+
+# Rule to link vmlinux - also used during CONFIG_KALLSYMS
+# May be overridden by arch/$(ARCH)/Makefile
+quiet_cmd_vmlinux__ ?= LD      $@
+      cmd_vmlinux__ ?= $(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) -o $@ \
+      -T $(vmlinux-lds) $(vmlinux-init)                          \
+      --start-group $(vmlinux-main) --end-group                  \
+      $(filter-out $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) FORCE ,$^)
+
+# Generate new vmlinux version
+quiet_cmd_vmlinux_version = GEN     .version
+      cmd_vmlinux_version = set -e;                     \
+   . $(srctree)/scripts/mkversion > .tmp_version;   \
+   mv -f .tmp_version .version;         \
+   $(MAKE) $(build)=init
+
+# Generate System.map
+quiet_cmd_sysmap = SYSMAP 
+      cmd_sysmap = $(CONFIG_SHELL) $(srctree)/scripts/mksysmap
+
+# Link of vmlinux
+# If CONFIG_KALLSYMS is set .version is already updated
+# Generate System.map and verify that the content is consistent
 
 define rule_vmlinux__
-   +set -e;                     \
-   $(if $(filter .tmp_kallsyms%,$^),,            \
-     echo '  GEN     .version';               \
-     . $(srctree)/scripts/mkversion > .tmp_version;      \
-     mv -f .tmp_version .version;               \
-     $(MAKE) $(build)=init;               \
-   )                        \
-   $(if $($(quiet)cmd_vmlinux__),               \
-     echo '  $($(quiet)cmd_vmlinux__)' &&)          \
-   $(cmd_vmlinux__);                  \
-   echo 'cmd_$@ := $(cmd_vmlinux__)' > $(@D)/.$(@F).cmd
-endef
+   $(if $(CONFIG_KALLSYMS),,+$(call cmd,vmlinux_version))
 
-do_system_map = $(NM) $(1) | grep -v '\(compiled\)\|\(\.o$$\)\|\( [aUw] \)\|\(\.\.ng$$\)\|\(LASH[RL]DI\)' | sort > $(2)
+   $(call cmd,vmlinux__)
+   $(Q)echo 'cmd_$@ := $(cmd_vmlinux__)' > $(@D)/.$(@F).cmd
 
-LDFLAGS_vmlinux += -T arch/$(ARCH)/kernel/vmlinux.lds.s
+   $(Q)$(if $($(quiet)cmd_sysmap),                 \
+     echo '  $($(quiet)cmd_sysmap) System.map' &&) \
+   $(cmd_sysmap) $@ System.map;                    \
+   if [ $$? -ne 0 ]; then                          \
+      rm -f $@;                               \
+      /bin/false;                             \
+   fi;
+   $(verify_kallsyms)
+endef
 
-#   Generate section listing all symbols and add it into vmlinux
-#   It's a three stage process:
-#   o .tmp_vmlinux1 has all symbols and sections, but __kallsyms is
-#     empty
-#     Running kallsyms on that gives us .tmp_kallsyms1.o with
-#     the right size
-#   o .tmp_vmlinux2 now has a __kallsyms section of the right size,
-#     but due to the added section, some addresses have shifted
-#     From here, we generate a correct .tmp_kallsyms2.o
-#   o The correct .tmp_kallsyms2.o is linked into the final vmlinux.
-#   o Verify that the System.map from vmlinux matches the map from
-#     .tmp_vmlinux2, just in case we did not generate kallsyms correctly.
-#   o If CONFIG_KALLSYMS_EXTRA_PASS is set, do an extra pass using
-#     .tmp_vmlinux3 and .tmp_kallsyms3.o.  This is only meant as a
-#     temporary bypass to allow the kernel to be built while the
-#     maintainers work out what went wrong with kallsyms.
 
 ifdef CONFIG_KALLSYMS
+# Generate section listing all symbols and add it into vmlinux $(kallsyms.o)
+# It's a three stage process:
+# o .tmp_vmlinux1 has all symbols and sections, but __kallsyms is
+#   empty
+#   Running kallsyms on that gives us .tmp_kallsyms1.o with
+#   the right size - vmlinux version (uname -v) is updated during this step
+# o .tmp_vmlinux2 now has a __kallsyms section of the right size,
+#   but due to the added section, some addresses have shifted.
+#   From here, we generate a correct .tmp_kallsyms2.o
+# o The correct .tmp_kallsyms2.o is linked into the final vmlinux.
+# o Verify that the System.map from vmlinux matches the map from
+#   .tmp_vmlinux2, just in case we did not generate kallsyms correctly.
+# o If CONFIG_KALLSYMS_EXTRA_PASS is set, do an extra pass using
+#   .tmp_vmlinux3 and .tmp_kallsyms3.o.  This is only meant as a
+#   temporary bypass to allow the kernel to be built while the
+#   maintainers work out what went wrong with kallsyms.
 
 ifdef CONFIG_KALLSYMS_EXTRA_PASS
 last_kallsyms := 3
@@ -569,47 +641,58 @@
 
 kallsyms.o := .tmp_kallsyms$(last_kallsyms).o
 
-define rule_verify_kallsyms
-   @$(call do_system_map, .tmp_vmlinux$(last_kallsyms), .tmp_System.map)
-   @cmp -s System.map .tmp_System.map || \
-      (echo Inconsistent kallsyms data, try setting CONFIG_KALLSYMS_EXTRA_PASS ; rm .tmp_kallsyms* ; false)
+define verify_kallsyms
+   $(Q)$(if $($(quiet)cmd_sysmap),                       \
+     echo '  $($(quiet)cmd_sysmap) .tmp_System.map' &&)  \
+     $(cmd_sysmap) .tmp_vmlinux$(last_kallsyms) .tmp_System.map
+   $(Q)cmp -s System.map .tmp_System.map ||              \
+      (echo Inconsistent kallsyms data;             \
+       echo Try setting CONFIG_KALLSYMS_EXTRA_PASS; \
+       rm .tmp_kallsyms* ; /bin/false )
+endef
+
+# Update vmlinux version before link
+# Use + in front of this rule to silent warning about make -j1
+cmd_ksym_ld = $(cmd_vmlinux__)
+define rule_ksym_ld
+   +$(call cmd,vmlinux_version)
+   $(call cmd,vmlinux__)
+   $(Q)echo 'cmd_$@ := $(cmd_vmlinux__)' > $(@D)/.$(@F).cmd
 endef
 
+# Generate .S file with all kernel symbols
 quiet_cmd_kallsyms = KSYM    $@
-cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) $(foreach x,$(CONFIG_KALLSYMS_ALL),--all-symbols) > $@
+      cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \
+                     $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@
 
 .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE
    $(call if_changed_dep,as_o_S)
 
-.tmp_kallsyms%.S: .tmp_vmlinux%
+.tmp_kallsyms%.S: .tmp_vmlinux% $(KALLSYMS)
    $(call cmd,kallsyms)
 
-.tmp_vmlinux1: $(vmlinux-objs) arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
-   $(call if_changed_rule,vmlinux__)
-
-.tmp_vmlinux2: $(vmlinux-objs) .tmp_kallsyms1.o arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
-   $(call if_changed_rule,vmlinux__)
+# .tmp_vmlinux1 must be complete except kallsyms, so update vmlinux version
+.tmp_vmlinux1: $(vmlinux-lds) $(vmlinux-all) FORCE
+   $(call if_changed_rule,ksym_ld)
 
-.tmp_vmlinux3: $(vmlinux-objs) .tmp_kallsyms2.o arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
-   $(call if_changed_rule,vmlinux__)
-
-endif
+.tmp_vmlinux2: $(vmlinux-lds) $(vmlinux-all) .tmp_kallsyms1.o FORCE
+   $(call if_changed,vmlinux__)
 
-#   Finally the vmlinux rule
+.tmp_vmlinux3: $(vmlinux-lds) $(vmlinux-all) .tmp_kallsyms2.o FORCE
+   $(call if_changed,vmlinux__)
 
-define rule_vmlinux
-   $(rule_vmlinux__); \
-   $(call do_system_map, $@, System.map)
-   $(rule_verify_kallsyms)
-endef
+# Needs to visit scripts/ before $(KALLSYMS) can be used.
+$(KALLSYMS): scripts ;
 
-vmlinux: $(vmlinux-objs) $(kallsyms.o) arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
-   $(call if_changed_rule,vmlinux)
+endif # ifdef CONFIG_KALLSYMS
 
-#   The actual objects are generated when descending, 
-#   make sure no implicit rule kicks in
+# vmlinux image - including updated kernel symbols
+vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) $(kallsyms.o) FORCE
+   $(call if_changed_rule,vmlinux__)
 
-$(sort $(vmlinux-objs)) arch/$(ARCH)/kernel/vmlinux.lds.s: $(vmlinux-dirs) ;
+# The actual objects are generated when descending, 
+# make sure no implicit rule kicks in
+$(sort $(vmlinux-init) $(vmlinux-main)) $(vmlinux-lds): $(vmlinux-dirs) ;
 
 # Handle descending into subdirectories listed in $(vmlinux-dirs)
 # Preset locale variables to speed up the build process. Limit locale
@@ -632,10 +715,10 @@
 # using a seperate output directory. This allows convinient use
 # of make in output directory
 prepare2:
-   $(Q)if [ ! $(srctree) -ef $(objtree) ]; then       \
-   $(CONFIG_SHELL) $(srctree)/scripts/mkmakefile      \
-       $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL) \
-       > $(objtree)/Makefile;                         \
+   $(Q)if /usr/bin/env test ! $(srctree) -ef $(objtree); then \
+   $(CONFIG_SHELL) $(srctree)/scripts/mkmakefile              \
+       $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL)         \
+       > $(objtree)/Makefile;                                 \
    fi
 
 # prepare1 is used to check if we are building in a separate output directory,
@@ -667,7 +750,7 @@
 #   Leave this as default for preprocessing vmlinux.lds.S, which is now
 #   done in arch/$(ARCH)/kernel/Makefile
 
-export AFLAGS_vmlinux.lds.o += -P -C -U$(ARCH)
+export CPPFLAGS_vmlinux.lds += -P -C -U$(ARCH)
 
 # Single targets
 # ---------------------------------------------------------------------------
@@ -706,8 +789,8 @@
 # Generate some files
 # ---------------------------------------------------------------------------
 
-#   version.h changes when $(KERNELRELEASE) etc change, as defined in
-#   this Makefile
+# KERNELRELEASE can change from a few different places, meaning version.h
+# needs to be updated, so this check is forced on all builds
 
 uts_len := 64
 
@@ -722,7 +805,7 @@
    )
 endef
 
-include/linux/version.h: Makefile
+include/linux/version.h: $(srctree)/Makefile FORCE
    $(call filechk,version.h)
 
 # ---------------------------------------------------------------------------
@@ -922,7 +1005,13 @@
    @echo  '  rpm        - Build a kernel as an RPM package'
    @echo  '  tags/TAGS     - Generate tags file for editors'
    @echo  '  cscope     - Generate cscope index'
+   @echo  ''
+   @echo  'Static analysers'
+   @echo  '  buildcheck      - List dangling references to vmlinux discarded sections'
+   @echo  '                    and init sections from non-init sections'
    @echo  '  checkstack      - Generate a list of stack hogs'
+   @echo  '  namespacecheck  - Name space analysis on compiled kernel'
+   @echo  ''
    @echo  'Kernel packaging:'
    @$(MAKE) -f $(package-dir)/Makefile help
    @echo  ''
@@ -940,7 +1029,8 @@
 
    @echo  '  make V=0|1 [targets] 0 => quiet build (default), 1 => verbose build'
    @echo  '  make O=dir [targets] Locate all output files in "dir", including .config'
-   @echo  '  make C=1   [targets] Check all c source with checker tool'
+   @echo  '  make C=1   [targets] Check all c source with $$CHECK (sparse)'
+   @echo  '  make C=2   [targets] Force check of all c source with $$CHECK (sparse)'
    @echo  ''
    @echo  'Execute "make" or "make all" to build all targets marked with [*] '
    @echo  'For further info see the ./README file'
@@ -1081,8 +1171,11 @@
       | xargs $(PERL) -w scripts/checkversion.pl
 
 buildcheck:
-   $(PERL) scripts/reference_discarded.pl
-   $(PERL) scripts/reference_init.pl
+   $(PERL) $(srctree)/scripts/reference_discarded.pl
+   $(PERL) $(srctree)/scripts/reference_init.pl
+
+namespacecheck:
+   $(PERL) $(srctree)/scripts/namespace.pl
 
 endif #ifeq ($(config-targets),1)
 endif #ifeq ($(mixed-targets),1)
@@ -1119,13 +1212,22 @@
   include $(cmd_files)
 endif
 
+# Execute command and generate cmd file
+if_changed = $(if $(strip $? \
+                $(filter-out $(cmd_$(1)),$(cmd_$@))\
+           $(filter-out $(cmd_$@),$(cmd_$(1)))),\
+   @set -e; \
+   $(if $($(quiet)cmd_$(1)),echo '  $(subst ','\'',$($(quiet)cmd_$(1)))';) \
+   $(cmd_$(1)); \
+   echo 'cmd_$@ := $(subst $$,$$$$,$(subst ','\'',$(cmd_$(1))))' > $(@D)/.$(@F).cmd)
+
+
 # execute the command and also postprocess generated .d dependencies
 # file
-
 if_changed_dep = $(if $(strip $? $(filter-out FORCE $(wildcard $^),$^)\
                 $(filter-out $(cmd_$(1)),$(cmd_$@))\
            $(filter-out $(cmd_$@),$(cmd_$(1)))),\
-   @set -e; \
+   $(Q)set -e; \
    $(if $($(quiet)cmd_$(1)),echo '  $(subst ','\'',$($(quiet)cmd_$(1)))';) \
    $(cmd_$(1)); \
    scripts/basic/fixdep $(depfile) $@ '$(subst $$,$$$$,$(subst ','\'',$(cmd_$(1))))' > $(@D)/.$(@F).tmp; \
@@ -1139,7 +1241,7 @@
 if_changed_rule = $(if $(strip $? \
                      $(filter-out $(cmd_$(1)),$(cmd_$(@F)))\
                 $(filter-out $(cmd_$(@F)),$(cmd_$(1)))),\
-                  @$(rule_$(1)))
+                  $(Q)$(rule_$(1)))
 
 # If quiet is set, only print short version of command